Add missing Confluent repo in record decoder module #17243
Conversation
| <repositories> | ||
| <repository> | ||
| <id>confluent</id> | ||
| <url>https://packages.confluent.io/maven/</url> |
There was a problem hiding this comment.
Will this make us hit confluent maven repo (first, before maven central) for all artifacts needed by this module?
There was a problem hiding this comment.
Took a look at the effective pom for this module. It is listed first so I think that means Maven will hit it first to find artifacts.
There was a problem hiding this comment.
yes, and that's not desireable.
pre-existing (trino-pinot, trino-kafka), so no change requested
I don't understand this part. The cache is based on recursive pom.xml hash so how could a pom.xml change use a cache? |
|
We restore cache from master if there's no hit on the exact key. |
|
Ah, seems so indeed - trino/.github/actions/setup/action.yml Lines 48 to 49 in d60b39d |
Description
#16836 added
io.confluent:kafka-protobuf-provider:jar:7.3.1as a dependency of thetrino-record-decodermodule, but didn't add the Confluent repository. The CI in the PR might have passed if it used a cached local Maven repository, but now is failing on master and other branches. Fixes #17230Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: